Finalize removal of liblog4cxx dependency#38
Merged
bchretien merged 5 commits intoroboptim:masterfrom Jun 29, 2018
Merged
Conversation
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 74.87% 74.87%
=======================================
Files 10 10
Lines 398 398
Branches 49 49
=======================================
Hits 298 298
Misses 63 63
Partials 37 37
Continue to review full report at Codecov.
|
This was referenced Feb 12, 2018
Member
|
Is it possible to merge this pull request in order to be able to merge PR#40 in roboptim-trajectory? |
Member
Author
|
@florent-lamiraux I wanted to solve the AppVeyor issue back then but never found the time, I guess the Windows build will fail until I find the motivation. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the work done in roboptim/roboptim-core#120.